add package version to the package list output #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
Racer159
requested changes
Jun 27, 2023
There was a problem hiding this comment.
The code LGTM but tangential to this story can you add a note to our Developer Workflow section of our CONTRIBUTING.md around issue assignment (noticed in review that the issue this tracks to had a comment for assignment: #1797).
We should change the verbiage from "Assign yourself" to something that simply encourages folks to submit PRs early when they start working on something - people cannot actually assign themselves to issues as that is only something a maintainer can do.
|
From discussions num 2 could be reworded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zarf package listnow shows the package version of deployed packages.Fixes #1797