Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1862 adr #1900

Merged
merged 7 commits into from
Jul 20, 2023
Merged

1862 adr #1900

merged 7 commits into from
Jul 20, 2023

Conversation

cmwylie19
Copy link
Contributor

@cmwylie19 cmwylie19 commented Jul 11, 2023

Description

ADR for decoupling the transform library from go code and allowing it to be used in TypeScript with Pepr.

Related Issue

Fixes #

Relates to #1632

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

cmwylie19 and others added 3 commits June 28, 2023 09:55
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 2227560
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/64b94c49e542d600082f23de
😎 Deploy Preview https://deploy-preview-1900--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Racer159
Racer159 previously approved these changes Jul 13, 2023
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as is though these small things should be fixed when the ADR is finalized

adr/0019-decouple-transformation-library-from-zarf.md Outdated Show resolved Hide resolved
adr/0019-decouple-transformation-library-from-zarf.md Outdated Show resolved Hide resolved
cmwylie19 and others added 3 commits July 20, 2023 11:01
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit 02150cf into main Jul 20, 2023
@Racer159 Racer159 deleted the 1862-adr branch July 20, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants