Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to specify Zarf variables as filepaths #1906

Merged
merged 11 commits into from
Jul 19, 2023

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Jul 14, 2023

Description

This allows Zarf variables to be filepaths to be loaded on templating (without exceeding env var size limits) - similar to https://docs.gitlab.com/ee/ci/variables/#use-file-type-cicd-variables

Related Issue

Fixes #1372
Fixes #1852

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@Racer159 Racer159 added needs-docs PR Label - Docs required to merge needs-tests PR Label - Tests required to merge labels Jul 14, 2023
@netlify
Copy link

netlify bot commented Jul 14, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit a40f3f2
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/64b864a6b013450008a021a7

@Racer159 Racer159 requested review from mike-winberry, Madeline-UX and a team as code owners July 18, 2023 21:37
@Racer159 Racer159 removed needs-docs PR Label - Docs required to merge needs-tests PR Label - Tests required to merge labels Jul 18, 2023
src/pkg/packager/variables.go Outdated Show resolved Hide resolved
src/types/runtime.go Outdated Show resolved Hide resolved
src/pkg/utils/io.go Outdated Show resolved Hide resolved
src/pkg/utils/io.go Show resolved Hide resolved
@Racer159 Racer159 enabled auto-merge (squash) July 19, 2023 22:42
@Racer159 Racer159 merged commit 308e803 into main Jul 19, 2023
@Racer159 Racer159 deleted the 1372-variables-file-contents branch July 19, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart component inconsistent with Helm CLI deployment Allow Zarf Variable to be the contents of a file
2 participants