-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to specify Zarf variables as filepaths #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Racer159
added
needs-docs
PR Label - Docs required to merge
needs-tests
PR Label - Tests required to merge
labels
Jul 14, 2023
✅ Deploy Preview for zarf-docs canceled.
|
Racer159
requested review from
mike-winberry,
Madeline-UX and
a team
as code owners
July 18, 2023 21:37
Racer159
removed
needs-docs
PR Label - Docs required to merge
needs-tests
PR Label - Tests required to merge
labels
Jul 18, 2023
YrrepNoj
suggested changes
Jul 19, 2023
YrrepNoj
reviewed
Jul 19, 2023
YrrepNoj
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows Zarf variables to be filepaths to be loaded on templating (without exceeding env var size limits) - similar to https://docs.gitlab.com/ee/ci/variables/#use-file-type-cicd-variables
Related Issue
Fixes #1372
Fixes #1852
Type of change
Checklist before merging