Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add backwards compatibility validation to package deploy #1909

Merged
merged 28 commits into from
Aug 2, 2023

Conversation

lucasrod16
Copy link
Contributor

@lucasrod16 lucasrod16 commented Jul 18, 2023

Description

  • Adds the latest version of Zarf with no breaking package structure changes to build metadata in packages on package create

  • Validates the running Zarf CLI version is not less (older) than the last non-breaking version in a package on package deploy. Zarf will throw a warning to the user if the CLI version is older than the last non-breaking version to warn before deploying packages that are potentially affected by breaking changes.

Related Issue

Fixes #1760

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit da96dcd
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/64c9c397f4dfaf00086c4ed6

@lucasrod16 lucasrod16 added the needs-tests PR Label - Tests required to merge label Jul 18, 2023
@lucasrod16 lucasrod16 marked this pull request as draft July 18, 2023 21:56
@lucasrod16 lucasrod16 removed the needs-tests PR Label - Tests required to merge label Jul 19, 2023
@lucasrod16 lucasrod16 marked this pull request as ready for review July 20, 2023 21:23
@lucasrod16 lucasrod16 requested review from mike-winberry, Madeline-UX and a team as code owners July 20, 2023 21:23
src/config/config.go Outdated Show resolved Hide resolved
src/pkg/packager/common.go Outdated Show resolved Hide resolved
src/pkg/packager/create.go Outdated Show resolved Hide resolved
src/pkg/packager/deploy.go Outdated Show resolved Hide resolved
src/types/package.go Outdated Show resolved Hide resolved
@lucasrod16 lucasrod16 requested a review from Racer159 July 28, 2023 16:55
YrrepNoj
YrrepNoj previously approved these changes Jul 28, 2023
Copy link
Contributor

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR looks good.

I added a comment about a style preference for your consideration. If you prefer it the way you have it now feel free to resolve the comment :)

src/pkg/packager/common.go Outdated Show resolved Hide resolved
@lucasrod16 lucasrod16 requested a review from cmwylie19 as a code owner August 1, 2023 18:43
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Racer159 Racer159 enabled auto-merge (squash) August 2, 2023 02:53
@Racer159 Racer159 merged commit b6611b3 into main Aug 2, 2023
@Racer159 Racer159 deleted the 1760-validate-backwards-compatibility branch August 2, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail fast when handling incompatible package
3 participants