Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the error return for building helm repositories #1911

Merged
merged 6 commits into from
Jul 27, 2023
Merged

Fix the error return for building helm repositories #1911

merged 6 commits into from
Jul 27, 2023

Conversation

Racer159
Copy link
Contributor

Description

This fixes an issue with error returns when building the dependencies for a Helm chart.

Related Issue

Relates to #1875

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Jul 20, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit d020c81
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/64c2ded0a832500008f0b0fd

@Racer159 Racer159 mentioned this pull request Jul 20, 2023
Merged
5 tasks
cmwylie19
cmwylie19 previously approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

YrrepNoj
YrrepNoj previously approved these changes Jul 27, 2023
View reviewed changes
@Racer159 Racer159 enabled auto-merge (squash) July 27, 2023 20:25
@Racer159 Racer159 dismissed stale reviews from YrrepNoj and cmwylie19 via d020c81 July 27, 2023 21:17
@Racer159 Racer159 merged commit b114cbf into main Jul 27, 2023
@Racer159 Racer159 deleted the 1875-fix-helm-repo-build-error branch July 27, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YrrepNoj YrrepNoj YrrepNoj approved these changes

@cmwylie19 cmwylie19 cmwylie19 left review comments

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@Noxsios Noxsios Awaiting requested review from Noxsios

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Racer159 @cmwylie19 @YrrepNoj