Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zarf package mirror command introduction #1913

Merged
merged 20 commits into from
Sep 6, 2023
Merged

zarf package mirror command introduction #1913

merged 20 commits into from
Sep 6, 2023

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Jul 21, 2023

Description

This adds a command that mirrors artifacts from a package and pushes them to their airgap equivalents

Related Issue

Fixes #N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 7eca55d
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/64f8c04801ab3f000862627d
😎 Deploy Preview https://deploy-preview-1913--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Racer159 Racer159 changed the title Zarf unload command introduction Zarf mirror command introduction Jul 21, 2023
@Racer159 Racer159 changed the title Zarf mirror command introduction zarf package mirror command introduction Jul 21, 2023
@Racer159 Racer159 added needs-docs PR Label - Docs required to merge needs-tests PR Label - Tests required to merge labels Jul 21, 2023
@Madeline-UX
Copy link
Contributor

@Racer159 Created a test for naming of new command. Results of the test will appear on the Maze Results page Planning to get participants early next week -

@laurentiusoica
Copy link

Are there plans to include mirroring for helm charts as well? And also configuration to control the git repository names when mirroring?

@Racer159 Racer159 requested a review from cmwylie19 as a code owner August 31, 2023 13:01
@Racer159 Racer159 removed the needs-tests PR Label - Tests required to merge label Sep 1, 2023
src/config/config.go Outdated Show resolved Hide resolved
src/cmd/package.go Outdated Show resolved Hide resolved
src/cmd/package.go Outdated Show resolved Hide resolved
src/pkg/packager/mirror.go Outdated Show resolved Hide resolved
src/pkg/packager/mirror.go Outdated Show resolved Hide resolved
src/pkg/packager/mirror.go Outdated Show resolved Hide resolved
Racer159 and others added 3 commits September 2, 2023 01:58
Co-authored-by: razzle <harry@razzle.cloud>
Co-authored-by: razzle <harry@razzle.cloud>
@Racer159 Racer159 removed the needs-docs PR Label - Docs required to merge label Sep 6, 2023
Copy link
Contributor

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change deploy runtime to deployment runtime but i don't think that should hold up this PR. Otherwise LGTM

examples/dos-games/README.md Outdated Show resolved Hide resolved
Co-authored-by: Case Wylie <cmwylie19@defenseunicorns.com>
Copy link
Contributor

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants