Allow for the injector to be built in docker #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
Noxsios
reviewed
Jul 23, 2023
Noxsios
reviewed
Jul 23, 2023
|
LGTM |
YrrepNoj
previously approved these changes
Jul 26, 2023
cmwylie19
reviewed
Aug 2, 2023
Comment on lines
+154
to
+156
| build-injector-linux: ## Build the Zarf injector for AMD64 and ARM64 | ||
| docker run --rm --user "$(id -u)":"$(id -g)" -v $$PWD/src/injector:/usr/src/zarf-injector -w /usr/src/zarf-injector rust:1.71.0-bookworm make build-injector-linux | ||
|
|
There was a problem hiding this comment.
seems to be an extra $ in there
cmwylie19
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows building the injector on more systems and migrates its release to GHCR to avoid issues with Docker Hub.
Related Issue
Fixes #N/A
Type of change
Checklist before merging