Use UID and GID for USER in Dockerfile #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves issue #1921. On clusters that strictly enforce no root containers via an Admission Controller, they can't determine that a named user isn't 0 in the container. This changes the container to identify the USER by UID and GID so the admission controller can allow this through. Chainguard documents the UID and GID of nonroot https://edu.chainguard.dev/chainguard/chainguard-images/reference/static/overview/#users
flickerfly
requested review from
jeff-mccoy,
YrrepNoj,
Racer159 and
Noxsios
as code owners
✅ Deploy Preview for zarf-docs canceled.
|
Racer159
requested changes
Jul 27, 2023
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
YrrepNoj
previously approved these changes
Jul 27, 2023
Racer159
approved these changes
Jul 27, 2023
YrrepNoj
approved these changes
Jul 27, 2023
|
Thank you! If I understand right, looks like you folks as the vendor are also owners on the Repo1 equivalent so I'll make the connection. https://repo1.dso.mil/dsop/opensource/defenseunicorns/zarf/zarf-agent/-/issues/39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On clusters that strictly enforce no root containers via an Admission Controller, they can't determine that a named user isn't 0 in the container. This changes the container to identify the USER by UID and GID so the admission controller can allow this through.
Chainguard documents the UID and GID of nonroot https://edu.chainguard.dev/chainguard/chainguard-images/reference/static/overview/#users
Related Issue
Fixes #1921
Type of change
Checklist before merging