Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Standardize usage of <TabItem> tag to aid conversion. #1948

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

bdfinst
Copy link
Contributor

@bdfinst bdfinst commented Aug 7, 2023

Description

The <TabItem> component had inconsistent usage, making conversion logic more complex than needed. I've standardized the usage to make the conversion more straightforward.

...

Related Issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 5d344ed
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/64d0e95f81c2aa0008e36186
😎 Deploy Preview https://deploy-preview-1948--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdfinst bdfinst added the documentation 📘 Improvements or additions to documentation label Aug 7, 2023
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit b693fad into main Aug 7, 2023
@Racer159 Racer159 deleted the standardize-tabs branch August 7, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📘 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants