refactor DoHostnamesMatch #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
cmwylie19
requested review from
jeff-mccoy,
Racer159 and
Noxsios
as code owners
✅ Deploy Preview for zarf-docs canceled.
|
lucasrod16
reviewed
Aug 7, 2023
Co-authored-by: Lucas Rodriguez <lucas.rodriguez9616@gmail.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
|
had some feedback from Wayne around the new network package. Re-factoring to address that comment (avoiding spagetti type pattern) |
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Racer159
requested changes
Aug 8, 2023
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using Zarf as a library for DoHostnamesMatch you get all of the message dependencies. This PR is a feature to remove those dependencies and still get the same functionality with a small footprint.
Related Issue
Fixes #1949
Relates to #1949
Type of change
Checklist before merging