Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve edge cases with --tmpdir behavior #2000

Merged
merged 4 commits into from
Sep 3, 2023
Merged

Resolve edge cases with --tmpdir behavior #2000

merged 4 commits into from
Sep 3, 2023

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Sep 1, 2023

Description

This PR resolves edge cases with --tmpdir behavior by always using the specified temp dir in commands and always making a unique sub folder for each zarf run.

Related Issue

Fixes #N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit bde5e7b
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/64f2dcbec3eff100087b50c8
😎 Deploy Preview https://deploy-preview-2000--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cmwylie19
cmwylie19 previously approved these changes Sep 1, 2023
Copy link
Contributor

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/pkg/utils/io.go Outdated Show resolved Hide resolved
src/pkg/utils/io.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants