-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds a hint when the release might be empty #2003
Merged
Racer159
merged 6 commits into
zarf-dev:main
from
radiusmethod:feature/no-description-hint
Sep 18, 2023
Merged
adds a hint when the release might be empty #2003
Racer159
merged 6 commits into
zarf-dev:main
from
radiusmethod:feature/no-description-hint
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgershman
requested review from
jeff-mccoy,
cmwylie19,
Racer159 and
Noxsios
as code owners
September 1, 2023 22:19
✅ Deploy Preview for zarf-docs canceled.
|
Racer159
requested changes
Sep 2, 2023
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Racer159
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Noxsios
approved these changes
Sep 18, 2023
cmwylie19
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This assists when you may include a
bigbang
package but for some reason a dependency is not included. A good example of this is when you try to includemattermost
andmattermostOperator
but you forget, or don't know to includeminioOperator
. The extension attempts to install it, but doesn't include the name of what it's trying to install. This gives a hint by including the namespace in the output. There might be a better way to solve this, but this seems to help me figure out what to do next.Without this the output is:
With this change the output is:
Related Issue
N/A
Type of change
Checklist before merging