Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a hint when the release might be empty #2003

Merged
merged 6 commits into from
Sep 18, 2023

Conversation

dgershman
Copy link
Contributor

Description

This assists when you may include a bigbang package but for some reason a dependency is not included. A good example of this is when you try to include mattermost and mattermostOperator but you forget, or don't know to include minioOperator. The extension attempts to install it, but doesn't include the name of what it's trying to install. This gives a hint by including the namespace in the output. There might be a better way to solve this, but this seems to help me figure out what to do next.

Without this the output is:

Big Bang Helm Release `` to be ready

With this change the output is:

Big Bang Helm Release `` to be ready (Namespace: bigbang.minio-operator)

Related Issue

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 6ff25b7
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/650879d2d83382000860b515

src/extensions/bigbang/bigbang.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit 262b8ff into zarf-dev:main Sep 18, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants