-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support cosign signatures / attestations and discover in zarf prepare find-images
#2027
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it is still draft but figured I would add some initial comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to also update the fuzzy image regex to this while you touch the find images code:
["|=]([a-z0-9\-.\/:]+:[\w.\-]*[a-z\.\-][\w.\-]*)"
Welcome feedback on whether it makes sense and the full context is here: https://kubernetes.slack.com/archives/C03B6BJAUJ3/p1696639896292219?thread_ts=1696585484.114289&cid=C03B6BJAUJ3 (edited)
zarf prepare find-images
zarf prepare find-images
zarf prepare find-images
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now the error was handled
Description
Output from @rjferguson21 and my dash day's explorations of this.
This PR includes:
zarf prepare find-images
Several TODOs for follow-on work based on the issue/other needs:
<digest>.sig
. When zarf does itsAddImageAnnotation
this could change the image digest, making it so that the signature is no longer at the correct tag. Images already having that annotation are unaffected (which is why this works OK for Ironbank).Related Issue
Relates to #475
Type of change
Checklist before merging