Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the node name instead of the hostname to build the injector pod #2119

Merged
merged 6 commits into from
Nov 6, 2023
+1 −1
Merged

fix: use the node name instead of the hostname to build the injector pod #2119

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4cd790d
fix: use the node name instead of the hostname to build the injector pod
Racer159 Oct 31, 2023
5147ee0
Add a test for this in CI
Racer159 Nov 1, 2023
c3040a5
Merge branch 'main' into 2110-use-node-name-instead-of-hostname
Racer159 Nov 1, 2023
9968864
Merge branch 'main' into 2110-use-node-name-instead-of-hostname
Racer159 Nov 4, 2023
7f9e1e5
Remove the incredibly cursed node name override (why @vmware ???)
Racer159 Nov 4, 2023
bb8cd18
Merge branch 'main' into 2110-use-node-name-instead-of-hostname
Racer159 Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/internal/cluster/injector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ func (c *Cluster) buildInjectionPod(node, image string, payloadConfigmaps []stri
pod.Labels[agentLabel] = "ignore"

// Bind the pod to the node the image was found on
pod.Spec.NodeSelector = map[string]string{"kubernetes.io/hostname": node}
pod.Spec.NodeName = node

// Do not try to restart the pod as it will be deleted/re-created instead
pod.Spec.RestartPolicy = corev1.RestartPolicyNever
Expand Down
Loading