Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add http request header timeout to help stalling image push #2319

Merged
merged 15 commits into from
Feb 23, 2024
Merged

fix: add http request header timeout to help stalling image push #2319

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f920a04
fix: multi-part tarballs being mismatched sizes
Racer159 Feb 19, 2024
9423b78
Merge branch 'main' into 2313-fix-multi-part-tarball-mismatched-sizes
Racer159 Feb 19, 2024
29cc6e2
update test to overcome 16MB buffer
Racer159 Feb 19, 2024
d5e9265
Merge branch 'main' into 2313-fix-multi-part-tarball-mismatched-sizes
Racer159 Feb 19, 2024
9e7e080
dynamically make a 50MiB file (more performant than a download)
Racer159 Feb 19, 2024
3157403
dynamically make a 50MiB file (more performant than a download)
Racer159 Feb 19, 2024
87794df
close the file for windows file handlers
Racer159 Feb 19, 2024
742378a
fix: test fixes to the image push timeout
Racer159 Feb 21, 2024
5ba4b94
Merge branch 'main' into hotfix-test-http-timeout
Racer159 Feb 21, 2024
9fef304
fix test
Racer159 Feb 21, 2024
84cd3e1
Merge branch 'main' into hotfix-test-http-timeout
Racer159 Feb 21, 2024
c552a75
Merge branch 'main' into hotfix-test-http-timeout
Racer159 Feb 21, 2024
53d47eb
Add comment explaining more about why this is here
Racer159 Feb 23, 2024
d659b17
Merge branch 'main' into hotfix-test-http-timeout
Racer159 Feb 23, 2024
bfb0481
Merge branch 'main' into hotfix-test-http-timeout
Racer159 Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/internal/packager/images/push.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ package images
import (
"fmt"
"net/http"
"time"

"github.com/defenseunicorns/zarf/src/config"
"github.com/defenseunicorns/zarf/src/pkg/cluster"
Expand Down Expand Up @@ -50,6 +51,8 @@ func (i *ImageConfig) PushToZarfRegistry() error {

httpTransport := http.DefaultTransport.(*http.Transport).Clone()
httpTransport.TLSClientConfig.InsecureSkipVerify = i.Insecure
// TODO (@WSTARR) This is set to match the TLSHandshakeTimeout to potentially mitigate effects of https://github.com/defenseunicorns/zarf/issues/1444
httpTransport.ResponseHeaderTimeout = 10 * time.Second
Noxsios marked this conversation as resolved.
Show resolved Hide resolved
progressBar := message.NewProgressBar(totalSize, fmt.Sprintf("Pushing %d images to the zarf registry", len(i.ImageList)))
defer progressBar.Stop()
craneTransport := utils.NewTransport(httpTransport, progressBar)
Expand Down
Loading