Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Big Bang example to PR #237 #267

Conversation

RothAndrew
Copy link
Contributor

No description provided.

@@ -24,4 +24,4 @@ RestartSec=5s
ExecStartPre=/bin/sh -xc '! /usr/bin/systemctl is-enabled --quiet nm-cloud-setup.service'
ExecStartPre=-/sbin/modprobe br_netfilter
ExecStartPre=-/sbin/modprobe overlay
ExecStart=/usr/local/bin/k3s server --write-kubeconfig-mode=700
ExecStart=/usr/local/bin/k3s server --write-kubeconfig-mode=700 --disable traefik
Copy link
Contributor Author

@RothAndrew RothAndrew Feb 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeff-mccoy @YrrepNoj looking for feedback on this.

Reasons why I want to do it:

  • Consistent messaging. We are not expecting Ingresses to be available which is why we have the zarf connect command. The user should be expected to deploy their own ingress controller if they want one. We can do some documentation or a Zarf package to make that easy.
  • Big Bang compatibility. If we do this we can deploy Big Bang to the K3s cluster that Zarf creates and not have to deal with 2 ingress controllers (regardless of whether they initially conflict with eachother or not)

I have not tested changing Istio back to 443 to see if it conflicts with Traefik. I suspect it will, but given my points above, it doesn't matter if it does or not, since having 2 different ingress controllers is not something that is desirable in most cases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine with me for now, but I think we need more user discover around appliance mode to understand the need (or not) for an ingress vs just zarf connect. My guess is we will need to keep the ingress as an option but need to better leverage ingressclassname down the road and settle on a pattern. So sure remove it now, but at some point in the future we may need it (or another ingress) for appliance examples. That might be a great way to leverage #250.

@RothAndrew RothAndrew merged commit 614b4d3 into multi-distro-support Feb 4, 2022
@RothAndrew RothAndrew deleted the feature/multi-distro-support-update-big-bang-example branch February 4, 2022 21:59
RothAndrew added a commit that referenced this pull request Feb 7, 2022
jeff-mccoy pushed a commit that referenced this pull request Feb 8, 2022
jeff-mccoy pushed a commit that referenced this pull request Feb 8, 2022
jeff-mccoy added a commit that referenced this pull request Feb 8, 2022
jeff-mccoy pushed a commit that referenced this pull request Feb 8, 2022
Signed-off-by: Jeff McCoy <code@jeffm.us>
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Signed-off-by: Jeff McCoy <code@jeffm.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants