-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: override tunnel details with user-provided settings #2707
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2707 +/- ##
==========================================
- Coverage 19.44% 19.44% -0.01%
==========================================
Files 171 171
Lines 12161 12163 +2
==========================================
Hits 2365 2365
- Misses 9495 9497 +2
Partials 301 301 ☔ View full report in Codecov by Sentry. |
I'll add tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this, a few comments
Codecov ReportAttention: Patch coverage is
|
@chaospuppy sorry just getting back to this. Since this PR was made we've started requiring DCO. Please follow the instructions under the details tab to get that fixed and we'll merge this PR. |
Sorry for the delay @AustinAbro321, I was out on PTO tail end of last week. It looks like you may have merged main, do you still require DCO for my commits? |
@chaospuppy We still do require DCO - I merged in main to just try and get those tests to pass (and see if it was a flake). Please feel encouraged to squash and push with everything signed :) |
Closing this MR in favor of #2841, which was branched from a fork of the new Zarf repo and has been signed-off on. |
Description
Provides a means for users to override tunnel details when a
target
is specifiedRelated Issue
Fixes #2665
Checklist before merging