-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: separate schema generation #2886
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚨 Try these New Features:
|
Good jobs getting this done. A couple of comments. Is the docs changes related to these changes or are we fixing this because we found out it was wrong during this work? We wont remove any dependency in the Zarf CLI in this change. Just making sure because the description makes it seem like we are reducing the amount of dependencies. The last thing is that I think this code should go in a I would like @schristoff input on this type of project structure. |
It's related to this work. Essentially we're copying the alpha schema to a different folder. I'm not deleting the original zarf.schema.json since many users rely on it. However once we're in v1 and users no longer need that original zarf.schema.json I'm thinking we can move all the schemas to the tools folder
Yeah my description was confusing, fixed it.
I would agree |
✅ Deploy Preview for zarf-docs canceled.
|
Removing the needs design flag, as I simplified this PR to only change where the schema is generated, rather than generating a schema for the apiVersion |
8c4bdb1
to
08fc321
Compare
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
08fc321
to
00c5d98
Compare
Description
This moves schema generation to it's own folder rather than being a command in Zarf
This doesn't remove the invopop/jsonschema from the Zarf CLI, however there is only one place left it is used. Likely this can be removed in a future PR and replaced with runtime validation.
zarf/src/api/v1beta1/component.go
Line 318 in 8100c69
Relates to #2788
Checklist before merging