chore: address clippy feedback #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joonas Bergius <joonas@bergi.us>
✅ Deploy Preview for zarf-docs canceled.
|
schristoff
approved these changes
Oct 17, 2024
|
Thank you for these improvements :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Jneville0815
pushed a commit
to radiusmethod/zarf
that referenced
this pull request
Dec 12, 2024
Signed-off-by: Joonas Bergius <joonas@bergi.us> Co-authored-by: schristoff <28318173+schristoff@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing the outstanding lints from Clippy:
unused_io_amountuseless_formatneedless_borrowThis should make it nicer to view the code in editors with Clippy enabled and make a CI workflow using Clippy not fail on the first run.
Related Issue
Fixes #
Relates to #
Checklist before merging