fix: modify the wait condition according to return values from earlier method call #3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r method call Signed-off-by: Maciej Szulik <maciej@defenseunicorns.com>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov ReportAttention: Patch coverage is
|
ittacco
pushed a commit
to ittacco/zarf
that referenced
this pull request
Nov 9, 2024
…r method call (zarf-dev#3020) Signed-off-by: Maciej Szulik <maciej@defenseunicorns.com> Signed-off-by: ittacco <lorenzo.tacconi1967@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discussed on slack, tl;dr is: currently no matter what
PackageSecretNeedsWaitmethod returns we just return the package, we need to invert the condition to wait, ie. return an error, to give theretry.DoWithDatato do its job.Related Issue
None
Checklist before merging