Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass context to helm install & upgrade #3031

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

AustinAbro321
Copy link
Contributor

Description

Helm has an easy way to pass context through during install and upgrade. We've since started passing context throughout Zarf, now that it's available in these functions we should pass it through

Related Issue

Relates to #2647

Checklist before merging

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 requested review from a team as code owners September 25, 2024 19:49
Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit cf79e95
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66f46953cb042600085d7a94

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager/helm/chart.go 12.50% 7 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/packager/helm/chart.go 14.41% <12.50%> (ø)

Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit cd634e8 Sep 26, 2024
28 checks passed
@AustinAbro321 AustinAbro321 deleted the run-helm-with-context branch September 26, 2024 13:53
ittacco pushed a commit to ittacco/zarf that referenced this pull request Nov 9, 2024
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: ittacco <lorenzo.tacconi1967@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants