Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove cluster wait from packages and examples #3061

Merged
merged 17 commits into from
Oct 16, 2024

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Oct 2, 2024

Description

Depends on #3043

Once #3043 is merged, Zarf will use kstatus implicitly, thereby removing the need to wait for resources in many situations. Many of them were already covered by Helm wait also.

Related Issue

Relates to #2973

Checklist before merging

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 requested review from a team as code owners October 2, 2024 20:05
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 29d4b0b
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/670678f5e647c70008e01fd4
😎 Deploy Preview https://deploy-preview-3061--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@AustinAbro321 AustinAbro321 changed the title Remove wait from packages and examples chore: remove clsuter wait from packages and examples Oct 2, 2024
@AustinAbro321 AustinAbro321 changed the title chore: remove clsuter wait from packages and examples chore: remove cluster wait from packages and examples Oct 2, 2024
@AustinAbro321 AustinAbro321 marked this pull request as draft October 2, 2024 20:18
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 marked this pull request as ready for review October 9, 2024 12:34
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 56e48d4 Oct 16, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the remove-wait-from-packages-and-examples branch October 16, 2024 15:40
mjnagel pushed a commit to mjnagel/zarf that referenced this pull request Oct 21, 2024
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Micah Nagel <micah.nagel@defenseunicorns.com>
Jneville0815 pushed a commit to radiusmethod/zarf that referenced this pull request Dec 12, 2024
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants