Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add big-bang-umbrella folder back to Zarf examples... #308

Conversation

RothAndrew
Copy link
Contributor

@RothAndrew RothAndrew commented Feb 9, 2022

...with a README that redirects the reader to the new repo that replaced it

@RothAndrew RothAndrew self-assigned this Feb 9, 2022
@RothAndrew
Copy link
Contributor Author

/test all

@RothAndrew RothAndrew enabled auto-merge (squash) February 9, 2022 19:15
@RothAndrew
Copy link
Contributor Author

/test all

…redirects-to-new-software-factory-repo' into feature/add-example-folder-that-redirects-to-new-software-factory-repo
@RothAndrew
Copy link
Contributor Author

/test all

@RothAndrew
Copy link
Contributor Author

/test all

@RothAndrew
Copy link
Contributor Author

/test all

@RothAndrew
Copy link
Contributor Author

/test all

@RothAndrew
Copy link
Contributor Author

Ready for review & merge

@jeff-mccoy
Copy link
Contributor

@RothAndrew I'm confused on this PR a little bit, I see the readme updates and makes total sense, but "...also fix broken E2E test" seems completely unrelated to the topic PR. Now of course I don't mind combining these as I do it all the time, but think the PR topic needs to be updated because a README change and E2E tests are very different, very unrelated things. Thoughts?

@RothAndrew
Copy link
Contributor Author

I can pull the test change out into its own PR. I definitely want to practice what I preach 😄

@RothAndrew RothAndrew disabled auto-merge February 9, 2022 23:22
@RothAndrew
Copy link
Contributor Author

/test all

@RothAndrew
Copy link
Contributor Author

@jeff-mccoy ready for another review

@RothAndrew RothAndrew enabled auto-merge (squash) February 10, 2022 00:04
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@RothAndrew RothAndrew merged commit b34abb8 into master Feb 10, 2022
@RothAndrew RothAndrew deleted the feature/add-example-folder-that-redirects-to-new-software-factory-repo branch February 10, 2022 00:16
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
...with a README that redirects the reader to the new repo that replaced it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants