Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add logger to zarf destroy #3162

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

mkcp
Copy link
Contributor

@mkcp mkcp commented Oct 29, 2024

Description

Adds logger to zarf destroy and the code paths it depends on. As a side note, this cmd is very much in need a refactor and de-nesting.

Related Issue

Relates to #2576

Checklist before merging

Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp mkcp self-assigned this Oct 29, 2024
@mkcp mkcp requested review from a team as code owners October 29, 2024 19:35
@mkcp mkcp enabled auto-merge October 29, 2024 19:35
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 5e8bdd8
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/672138f85d16fe000839ad66

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 12.19512% with 36 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager/helm/destroy.go 0.00% 10 Missing ⚠️
src/pkg/cluster/zarf.go 0.00% 10 Missing ⚠️
src/cmd/destroy.go 0.00% 7 Missing ⚠️
src/pkg/cluster/namespace.go 0.00% 4 Missing ⚠️
src/internal/packager/helm/chart.go 0.00% 2 Missing ⚠️
src/pkg/cluster/cluster.go 0.00% 2 Missing ⚠️
src/pkg/packager/remove.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/cluster/state.go 61.32% <100.00%> (+0.30%) ⬆️
src/pkg/packager/remove.go 0.00% <0.00%> (ø)
src/internal/packager/helm/chart.go 12.84% <0.00%> (-0.04%) ⬇️
src/pkg/cluster/cluster.go 0.00% <0.00%> (ø)
src/pkg/cluster/namespace.go 39.13% <0.00%> (-3.73%) ⬇️
src/cmd/destroy.go 0.00% <0.00%> (ø)
src/internal/packager/helm/destroy.go 0.00% <0.00%> (ø)
src/pkg/cluster/zarf.go 12.36% <0.00%> (-0.46%) ⬇️

@mkcp mkcp added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2024
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 27879e7 Oct 30, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the mkcp/slog-zarf-destroy branch October 30, 2024 15:24
Jneville0815 pushed a commit to radiusmethod/zarf that referenced this pull request Dec 12, 2024
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants