Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose Helm skip schema validation option in Zarf schema #3165

Merged
merged 6 commits into from
Oct 31, 2024
Merged

feat: expose Helm skip schema validation option in Zarf schema #3165

merged 6 commits into from
Oct 31, 2024

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Oct 30, 2024 •
edited
Loading

Description

This introduces the SchemaValidation in the Zarf Helm Chart schema. This is important for the airgap use case. If a helm values schema reaches out to the internet it will break in the airgap

Related Issue

Fixes #3123
Fixes #3118

Checklist before merging

@AustinAbro321
skip schema validation
16b8ab3 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 requested review from a team as code owners October 30, 2024 15:15
@netlify Netlify
Copy link

netlify bot commented Oct 30, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 29875a3
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/672383172ce6bb000898e1d3

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/api/v1alpha1/component.go 0.00% 5 Missing ⚠️
src/internal/packager/helm/chart.go 0.00% 4 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/packager/helm/chart.go 12.70% <0.00%> (-0.18%) ⬇️
src/api/v1alpha1/component.go 0.00% <0.00%> (ø)

... and 25 files with indirect coverage changes

@AustinAbro321
update schema
c322db8 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
reword
34bcf38 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
no negatives
c9af371 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@jomeier
Copy link

jomeier commented Oct 31, 2024

Wow! Thanks that you fix that. You are my hero!

@AustinAbro321
rename bool func
d0f0674 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
reword desc
29875a3 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 changed the title feat: expose skip schema validation option in Zarf schema feat: expose Helm skip schema validation option in Zarf schema Oct 31, 2024
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 4c0521a Oct 31, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the disable-schema-validation-helm branch October 31, 2024 16:24
Jneville0815 pushed a commit to radiusmethod/zarf that referenced this pull request Dec 12, 2024
@AustinAbro321 @Jneville0815
feat: expose Helm skip schema validation option in Zarf schema (zarf-…
1492ec7 
…dev#3165)

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff schristoff approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
3 participants
@AustinAbro321 @jomeier @schristoff