Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: slog dev deploy #3176

Merged
merged 2 commits into from
Nov 4, 2024
Merged

chore: slog dev deploy #3176

merged 2 commits into from
Nov 4, 2024

Conversation

AustinAbro321
Copy link
Contributor

Description

Add the new logger to zarf dev deploy

Related Issue

Relates to #2576

Checklist before merging

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 requested review from a team as code owners November 4, 2024 16:39
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 8baede3
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6728fc5a617aaf0008b277b9

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/dev.go 0.00% 5 Missing ⚠️
src/pkg/packager/deploy.go 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/deploy.go 5.30% <0.00%> (-0.02%) ⬇️
src/pkg/packager/dev.go 0.00% <0.00%> (ø)

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 115f4f2 Nov 4, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the slog-dev-deploy branch November 4, 2024 19:18
Jneville0815 pushed a commit to radiusmethod/zarf that referenced this pull request Dec 12, 2024
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants