Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: slogging in agent #3190

Merged
merged 10 commits into from
Nov 5, 2024
Merged

feat: slogging in agent #3190

merged 10 commits into from
Nov 5, 2024

Conversation

AustinAbro321
Copy link
Contributor

Description

This changes the Zarf agent to use slog style logging

Related Issue

Fixes #3188

Checklist before merging

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 2f3215b
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/672a70c0567984000809f232

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/agent/start.go 0.00% 8 Missing ⚠️
src/internal/agent/http/proxy.go 0.00% 4 Missing ⚠️
src/internal/agent/http/admission/handler.go 57.14% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/agent/hooks/argocd-application.go 76.05% <100.00%> (+1.42%) ⬆️
src/internal/agent/hooks/argocd-repository.go 76.92% <100.00%> (+1.11%) ⬆️
src/internal/agent/hooks/flux-gitrepo.go 85.93% <100.00%> (+1.45%) ⬆️
src/internal/agent/hooks/flux-helmrepo.go 77.27% <100.00%> (+1.08%) ⬆️
src/internal/agent/hooks/flux-ocirepo.go 82.55% <100.00%> (+0.63%) ⬆️
src/internal/agent/hooks/pods.go 73.75% <100.00%> (+1.38%) ⬆️
src/internal/agent/http/admission/handler.go 58.53% <57.14%> (+0.51%) ⬆️
src/internal/agent/http/proxy.go 38.39% <0.00%> (-0.35%) ⬇️
src/internal/agent/start.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

AustinAbro321 and others added 9 commits November 5, 2024 18:14
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 marked this pull request as ready for review November 5, 2024 19:33
@AustinAbro321 AustinAbro321 requested review from a team as code owners November 5, 2024 19:33
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/config/lang/english.go Show resolved Hide resolved
src/internal/agent/hooks/pods.go Show resolved Hide resolved
src/internal/agent/http/admission/handler.go Show resolved Hide resolved
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit fd0eaee Nov 5, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the slog-zarf-agent branch November 5, 2024 20:20
Jneville0815 pushed a commit to radiusmethod/zarf that referenced this pull request Dec 12, 2024
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Zarf agent to use slog style logging
2 participants