Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exit on config file error #3193

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

AustinAbro321
Copy link
Contributor

Description

When we have a config file error that isn't not found we shouldn't ignore it

Related Issue

Fixes #3192

Checklist before merging

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 requested review from a team as code owners November 6, 2024 14:34
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 3696fff
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/672bcfd88748c6000896a6e6
😎 Deploy Preview https://deploy-preview-3193--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/cmd/common/viper.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/common/viper.go 0.00% 5 Missing ⚠️
src/cmd/root.go 0.00% 4 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/root.go 0.00% <0.00%> (ø)
src/cmd/common/viper.go 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 changed the title feat: stop ignoring config file errors feat: exit on config file error Nov 6, 2024
mkcp
mkcp previously approved these changes Nov 6, 2024
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rereviewed as discussed

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit bf0fb08 Nov 6, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the stop-ignoring-config-error branch November 6, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in zarf-config file should not be ignored
2 participants