Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: render tables and yaml on stdout #3226

Merged
merged 12 commits into from
Dec 5, 2024
Merged

feat: render tables and yaml on stdout #3226

merged 12 commits into from
Dec 5, 2024

Conversation

mkcp
Copy link
Contributor

@mkcp mkcp commented Nov 8, 2024 •
edited
Loading

Description

This PR introduces a TableWithWriter function, changes Table prints to use stdout, and changes common.ColorPrintYaml to use stdout.

Related Issue

Finishes #3223
Relates to #2576

Checklist before merging

@mkcp mkcp added the bug 🐞 Something isn't working label Nov 8, 2024
@mkcp mkcp self-assigned this Nov 8, 2024
@mkcp mkcp requested review from a team as code owners November 8, 2024 23:32
@netlify Netlify
Copy link

netlify bot commented Nov 8, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 54206ee
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6751f6b7cbd81200087cc3c9
😎 Deploy Preview https://deploy-preview-3226--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/message/message.go 0.00% 7 Missing ⚠️
src/pkg/utils/yaml.go 0.00% 2 Missing ⚠️
src/cmd/common/table.go 0.00% 1 Missing ⚠️
src/cmd/package.go 0.00% 1 Missing ⚠️
src/pkg/message/connect.go 0.00% 1 Missing ⚠️
src/pkg/message/credentials.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/connect.go 0.00% <ø> (ø)
src/cmd/dev.go 0.00% <ø> (ø)
src/cmd/root.go 0.00% <ø> (ø)
src/cmd/common/table.go 0.00% <0.00%> (ø)
src/cmd/package.go 0.00% <0.00%> (ø)
src/pkg/message/connect.go 0.00% <0.00%> (ø)
src/pkg/message/credentials.go 0.00% <0.00%> (ø)
src/pkg/utils/yaml.go 0.00% <0.00%> (ø)
src/pkg/message/message.go 11.32% <0.00%> (-0.45%) ⬇️

@mkcp
Copy link
Contributor Author

mkcp commented Nov 12, 2024

Hold off on review or merge, I need to look over the failing e2e tests.

@mkcp mkcp mentioned this pull request Nov 12, 2024
Closed
20 tasks
@mkcp
Copy link
Contributor Author

mkcp commented Nov 19, 2024

reworking this approach, we shouldn't have to update globals

mkcp added 4 commits November 21, 2024 10:50
@mkcp
make sure we render tables on stdout
9212937 
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp
make table writes to stdout reversible
1746458 
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp
store PTermWriter in message rather than relying on some Pterm info jank
f0238a0 
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp
remove global re-init hack for Stdout message prints using functions …
dbe02e9 
…with writers instead

Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp mkcp force-pushed the mkcp/tables-to-out branch from 40d31f0 to dbe02e9 Compare November 21, 2024 18:51
mkcp added 3 commits November 21, 2024 11:50
@mkcp
fix variables test to check stdout instead of stderr
5b580a1 
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp
Merge branch 'main' into mkcp/tables-to-out
ec7fcbd
@mkcp
06_create_sbom should see if stdout contains ref, not that it is only…
0095e72 
… ref now

Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp
Copy link
Contributor Author

mkcp commented Nov 21, 2024

Much better now - just chasing down failing tests.

@mkcp
25_helm check stdout not srderr for package deploy
36ab563 
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp mkcp mentioned this pull request Dec 5, 2024
Open
@mkcp mkcp changed the title feat: render tables on stdout feat: render tables and yaml on stdout Dec 5, 2024
mkcp added 4 commits December 5, 2024 09:21
@mkcp
fix some tests that were checking for content on stderr
3de9326 
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp
check stdout for oci_compose test
e9cdc84 
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp
import component tests from main
cd1a23f 
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp
Merge branch 'main' into mkcp/tables-to-out
54206ee
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit c979349 Dec 5, 2024
27 checks passed
@AustinAbro321 AustinAbro321 deleted the mkcp/tables-to-out branch December 5, 2024 20:00
@AustinAbro321 AustinAbro321 mentioned this pull request Dec 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinAbro321 AustinAbro321 AustinAbro321 approved these changes

Assignees

@mkcp mkcp

Labels
bug 🐞 Something isn't working
Projects
Zarf
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkcp @AustinAbro321