Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod volume mutate #3235

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Pod volume mutate #3235

wants to merge 3 commits into from

Conversation

a1994sc
Copy link
Contributor

@a1994sc a1994sc commented Nov 12, 2024

Description

This adds the ability for zarf to mutate pods that use the upcoming image-volume spec

spec:
  ...
  volumes:
  - name: volume
    image:
      reference: quay.io/crio/artifact:v1

to

spec:
  ...
  volumes:
  - name: volume
    image:
      reference: 127.0.0.1:31999/crio/artifact:v1-zarf-2568457951

As it uses the container run for pulling the image this should work like all the other mutations; however I need to test on a cluster that has the feature-gate enabled. So I will be leaving this as a draft-pr.

Related Links

Related Issues

Checklist before merging

Signed-off-by: Allen Conlon <software@conlon.dev>
Signed-off-by: Allen Conlon <software@conlon.dev>
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 7a6966c
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6733ea5c2cc897000884b96b

@a1994sc
Copy link
Contributor Author

a1994sc commented Nov 20, 2024

Off site convo: Austin and I came to the understanding that this likely will not be merged in until after the kubernetes enhancement is stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant