Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change agent to run as same user in dockerfile #3243

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Nov 18, 2024

Description

Fixes: #3244

This PR now sets stricter file permissions on the Zarf executable as well, this way if the permissions are changed in the future, it is tested.

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 466ac83
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/673b7a03663f7b000872bf30

@AustinAbro321 AustinAbro321 changed the title fix agent user fix: agent is running as wrong user Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅


🚨 Try these New Features:

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 marked this pull request as ready for review November 18, 2024 17:31
@AustinAbro321 AustinAbro321 requested review from a team as code owners November 18, 2024 17:31
@AustinAbro321 AustinAbro321 changed the title fix: agent is running as wrong user fix: change agent to run as dockerfile user Nov 18, 2024
@AustinAbro321 AustinAbro321 changed the title fix: change agent to run as dockerfile user fix: change agent to run as same user in dockerfile Nov 18, 2024
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 86c49d1 Nov 18, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the fix-agent-user branch November 18, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zarf agent deployments security context uses incorrect user / group
2 participants