Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unhide log-format flag #3251

Merged
merged 2 commits into from
Nov 20, 2024
Merged

chore: unhide log-format flag #3251

merged 2 commits into from
Nov 20, 2024

Conversation

AustinAbro321
Copy link
Contributor

Description

Relates to #3210

Checklist before merging

@AustinAbro321
unhide flag
18679b8 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 requested review from a team as code owners November 20, 2024 15:16
@netlify Netlify
Copy link

netlify bot commented Nov 20, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 1880668
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/673e09f4e2c26d0008ed6e82
😎 Deploy Preview https://deploy-preview-3251--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/internal.go 0.00% 1 Missing ⚠️
src/cmd/root.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/internal.go 0.00% <0.00%> (ø)
src/cmd/root.go 0.00% <0.00%> (ø)

🚨 Try these New Features:

@AustinAbro321
add hidden dummy flag
1880668 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
mkcp
mkcp approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit f4a3895 Nov 20, 2024
38 checks passed
@AustinAbro321 AustinAbro321 deleted the un-hide-log-format branch November 20, 2024 21:15
@mkcp mkcp mentioned this pull request Nov 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkcp mkcp mkcp approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AustinAbro321 @mkcp