feat: add logger to packager.Publish #3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m e2e test Signed-off-by: Kit Patella <kit@defenseunicorns.com>
✅ Deploy Preview for zarf-docs canceled.
|
mkcp
commented
Nov 21, 2024
Codecov ReportAttention: Patch coverage is
... and 3 files with indirect coverage changes 🚨 Try these New Features:
|
mkcp
commented
Nov 21, 2024
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
AustinAbro321
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This one ended up being really simple because most of the downstream code had already been ported to slog. I started updating the tests to use the new logging, but decided that it's better if we wait until we swap over to the default format. Added a couple review comments for discussion.
Related Issue
Relates to #2576
Checklist before merging