Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow init packages to be explicitly versioned #3286

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Dec 3, 2024

Description

In #3169 we allowed Zarf init packages to be explicitly versioned rather than always being the binary version. This behavior was not brought over to packager2

Checklist before merging

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 requested review from a team as code owners December 3, 2024 19:56
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 1f9324b
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/674f625f53d6d00008375664

@AustinAbro321 AustinAbro321 changed the title feat: allow init packages to be version to be set by user feat: allow init packages to be explicitly versioned Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/layout/create.go 0.00% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
src/internal/packager2/layout/create.go 56.77% <0.00%> (ø)

Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 5bf0791 Dec 5, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the version-init-package-packager2 branch December 5, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants