Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move console to default #3294

Merged
merged 4 commits into from
Dec 5, 2024
Merged

feat: move console to default #3294

merged 4 commits into from
Dec 5, 2024

Conversation

AustinAbro321
Copy link
Contributor

Description

Moves console to default, also marks the logger as beta

Related Issue

Relates to #3210

Checklist before merging

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 requested review from a team as code owners December 5, 2024 16:53
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 7b34c64
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6751ea9f6d54b70008fbe8ee
😎 Deploy Preview https://deploy-preview-3294--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/root.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/logger/logger.go 57.75% <100.00%> (+3.44%) ⬆️
src/cmd/root.go 0.00% <0.00%> (ø)

mkcp
mkcp previously approved these changes Dec 5, 2024
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired on this, approved

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@mkcp mkcp self-requested a review December 5, 2024 18:51
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 809167b Dec 5, 2024
38 checks passed
@AustinAbro321 AustinAbro321 deleted the default-to-console branch December 5, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants