Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Better Kubeconfig support #401

Closed
wants to merge 6 commits into from

Conversation

RothAndrew
Copy link
Contributor

@RothAndrew RothAndrew commented Mar 16, 2022

Description

Update the getRestConfig() function to provide Kubeconfig support that is closer to the capabilities of kubectl. Specifically, the ability to have multiple files specified in the KUBECONFIG environment variable (which is a default given the way it happens in client-go

Related Issue

Fixes #373

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before merging

  • Tests have been added/updated as necessary (add the needs-tests label)
  • Documentation has been updated as necessary (add the needs-docs label)
  • (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

@RothAndrew RothAndrew added needs-adr needs-docs PR Label - Docs required to merge needs-tests PR Label - Tests required to merge labels Mar 16, 2022
@RothAndrew
Copy link
Contributor Author

I don't think this needs an ADR, so I'll go ahead and pull that label.

@RothAndrew
Copy link
Contributor Author

Updated docs. Removing the needs-docs label.

Looking at what changes are needed for tests, if any.

@RothAndrew RothAndrew removed the needs-docs PR Label - Docs required to merge label Mar 16, 2022
@RothAndrew RothAndrew removed the needs-tests PR Label - Tests required to merge label Mar 16, 2022
@RothAndrew
Copy link
Contributor Author

Superseded by #407. Will do a new PR to add an E2E test for nonstandard KUBECONFIG files after #407 merges

@RothAndrew RothAndrew closed this Mar 19, 2022
@jeff-mccoy jeff-mccoy deleted the feature/better-kubeconfig-support branch March 22, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support KUBECONFIG env var that references multiple files
1 participant