destroy command actually checks for empty state #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shamelessly added a mostly unrelated commit to jump-start the test pipeline still GitHub went down yesterday and never started them. |
RothAndrew
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a Zarf install didn't complete successfully we might not have a
ZarfStatein the cluster to parse while doing azarf destroy --confirm. In cases like this the destroy command checks if there is noZarfStateto figure what to do. We recently stopped automatically adding a DistroIsUnknown string to the Distro field in the ZarfState but the destroy logic is still checking and expecting that string value.Related Issue
Fixes #403
Related to #371
Type of change