Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better KUBECONFIG support #410

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Better KUBECONFIG support #410

merged 2 commits into from
Mar 21, 2022

Conversation

RothAndrew
Copy link
Contributor

Description

Supports KUBECONFIG env vars in a way that more closely resembles how kubectl handles it, by utilizing the defaults in the client-go library

Related Issue

Related to #373 (but doesn't close it since it isn't adding a needed E2E test)

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before merging

  • Tests have been added/updated as necessary (add the needs-tests label)
  • Documentation has been updated as necessary (add the needs-docs label)
  • An ADR has been written as necessary (add the needs-adr label) [ 1 2 3 ]
  • (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

@RothAndrew RothAndrew requested a review from jeff-mccoy March 21, 2022 18:31
@RothAndrew RothAndrew self-assigned this Mar 21, 2022
@RothAndrew RothAndrew added the enhancement ✨ New feature or request label Mar 21, 2022
@RothAndrew RothAndrew enabled auto-merge (squash) March 21, 2022 18:56
@RothAndrew
Copy link
Contributor Author

@jeff-mccoy can I get a review on this one pls?

jeff-mccoy
jeff-mccoy approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thx

@RothAndrew RothAndrew merged commit 20f8444 into master Mar 21, 2022
@RothAndrew RothAndrew deleted the feature/better-kubeconfig-support-2 branch March 21, 2022 19:27
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
@RothAndrew
Better KUBECONFIG support (#410)
22f6e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-mccoy jeff-mccoy jeff-mccoy approved these changes

Assignees

@RothAndrew RothAndrew

Labels
enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RothAndrew @jeff-mccoy