fix(credentialParser): validate error before parsing password to avoid nil pointer. #418

[jsburckhardt]

…

Description

Even though the credentialParser is capturing an error during the parsing, it tries to retrieve the password without being sure the error is nil

Related Issue

Fixes # (issue)
#418

Type of change

• Bug fix (non-breaking change which fixes an issue)

Checklist before merging

• (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

[jeff-mccoy]

Thanks for making the PR and good catch.

[jeff-mccoy]

I have no preference, @YrrepNoj / @RothAndrew would it be cleaner to have @jsburckhardt sign and push or just have one of us do a sign-off on the commits like we did before for old commits?

[RothAndrew]

IMO we temporarily let admins override the requirement, ensuring that "Squash and Merge" is chosen, which will result in a commit signed by GitHub on master

[YrrepNoj]

Good catch with this change.

@jeff-mccoy I think it's perfectly reasonable to merge this in and have one of us do the signing later / as necessary.