Fixes #41, ensure standard naming for download helm charts #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM so far. Pulling down and testing with tiny-kafka example now. |
|
Error on creating the init package
Still investigating |
|
boo okay I may have to play with that, I thought that worked for me, but must have been mistaken |
|
I wrote a unit test for this. Okay if I push it? |
|
The issue lies in using |
|
Yeah I forgot to go back and check that when I was porting that from helms code, we can just turn off for now |
jeff-mccoy
deleted the
hotfix/helm-chart-naming-inconsistencies-breaks-some-charts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.