Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Big Bang Core example to BB v1.17.0 #67

Merged
merged 12 commits into from
Sep 29, 2021

Conversation

RothAndrew
Copy link
Contributor

@RothAndrew RothAndrew commented Sep 27, 2021

What/Why

  • Update Big Bang example to BB v1.17.0
  • Misc adjustments
    • Change port forwarding in Vagrantfile to directly forward the 2 new ports rather than expose different ports on the host than are exposed on the guest. From the user's perspective this makes no difference whatsoever but it feels cleaner to me
    • Update examples/big-bang/README.md: Add a table with all the service endpoints, usernames, and passwords, and add a note about needing to delete the EnvoyFilter from this bug
    • Update the NetworkPolicies with real a real CIDR
    • Update to the new bigbang.dev cert
    • Tweak resources for a better fit on a developer laptop
    • Reorder the YAML blocks in examples/big-bang/template/bigbang/values.yaml so they are in the same order as upstream's values.yaml (makes it easier to compare them)
    • Add a bunch of exclusions to the OPA Gatekeeper policies
    • Update the kubescape binary version

@RothAndrew RothAndrew self-assigned this Sep 27, 2021
@RothAndrew RothAndrew marked this pull request as ready for review September 29, 2021 20:29
@RothAndrew RothAndrew enabled auto-merge (squash) September 29, 2021 20:29
@jeff-mccoy
Copy link
Contributor

would you mind squashing these commits before merge?

@RothAndrew
Copy link
Contributor Author

It's set to squash on merge, is there a particular reason you want them squashed before the merge? There's a merge commit in between, so given my level of Git skill the best I'm comfortable with is

  • squashed commit
  • merge commit
  • squashed commit

@RothAndrew RothAndrew merged commit 4b939be into master Sep 29, 2021
@RothAndrew RothAndrew deleted the feature/upgrade-bb-version-in-example branch September 29, 2021 20:40
jeff-mccoy pushed a commit that referenced this pull request Feb 8, 2022
Signed-off-by: Jeff McCoy <code@jeffm.us>
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Signed-off-by: Jeff McCoy <code@jeffm.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants