Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release wheel for 3.10 #308

Closed
ianhi opened this issue Feb 17, 2022 · 14 comments
Closed

release wheel for 3.10 #308

ianhi opened this issue Feb 17, 2022 · 14 comments

Comments

@ianhi
Copy link

ianhi commented Feb 17, 2022

Minimal, reproducible code sample, a copy-pastable example if possible

mamba create -n test python=3.10
pip install numcodecs

Problem description

Above code spends some time building the wheel. Which may fail on some systems and also slows down install times. It would be great to bump CI python versions and release the new wheels.

Version and installation information

Please provide the following:

  • Value of numcodecs.__version__ 0.9.1
  • Version of Python interpreter 3.10
  • Operating system (Linux/Windows/Mac) linux
  • How NumCodecs was installed (e.g., "using pip into virtual environment", or "using conda"): pip
@martindurant
Copy link
Member

I think conda-forge has built for 3.10 already, if that will do.

@ianhi
Copy link
Author

ianhi commented Feb 17, 2022

I think conda-forge has built for 3.10 already, if that will do.

That's a good workaround - but I expect that there will be people who use pip primarily who will also run into this. e.g. i ran into this when doing pip install of different pacakge and it caught me off gaurd. No rush from me to fix, just wanted to bring it up

@martindurant
Copy link
Member

Sure, we need to update the release too.

@jakirkham
Copy link
Member

jakirkham commented Feb 17, 2022

We build wheels with cibuildwheel in this GH Action. AFAICT cibuildwheel already supports Python 3.10. So that should just work. Just need to update the version here.

Currently CI doesn't cover Python 3.10. So adding that would be good to do.

If someone would like to do a PR to add Python 3.10, that would be a good first step towards addressing this. Not expecting any major issues there, but if they come happy to discuss. @ianhi would you be interested in giving this a try? 🙂

@martindurant
Copy link
Member

cibuildwheel already supports Python 3.10

Yes, only if it is up to date

@jakirkham
Copy link
Member

Good point. Added to the comment above

@henryiii
Copy link
Contributor

henryiii commented Feb 17, 2022

This is one of the remaining not-on-3.10 yet wheels pyodide pyodide/pyodide#978. Do you still support Python 2? If so, then bumping to cibuildwheel 2.3.1 will drop 2.7 & 3.5 wheels - which is probably a good idea, since the only supported way to make them today is to use manylinux1, which is past EOL and hanging on by a thread. But you can split the job in two and use old cibuildwheel for old Python versions if that's the case. Otherwise, it should be a pretty simple bump.

@henryiii
Copy link
Contributor

Excellent, no Python <3.6 support, so should be a simple version bump. If you use our Action, you can even have GitHub Dependabot update this regularly for you.

Minor request, could you please remove the <4 from your Python requires? It causes issues for locking packages managers, and is discouraged. See https://iscinumpy.dev/post/bound-version-constraints/, https://discuss.python.org/t/requires-python-upper-limits, and cjolowicz/cookiecutter-hypermodern-python#1154 for some context / issues related to this.

@jakirkham
Copy link
Member

Excellent, no Python <3.6 support, so should be a simple version bump. If you use our Action, you can even have GitHub Dependabot update this regularly for you.

What would need to be done to set this up?

@jakirkham
Copy link
Member

On a side note, would be curious to learn more about how Pyodide & Zarr are being used together. Opened issue ( zarr-developers/community#43 ) for discussion on this 🙂

@jakirkham
Copy link
Member

We've now added Python 3.10 testing and enabled Python 3.10 wheel builds. All of this thanks to Henry's PR ( #309 ) 😀

Packages are not published yet, but think we are ready to do that next (assuming no other blockers)

@jakirkham
Copy link
Member

Wheels are now available for testing under 0.10.0a2. Thanks @joshmoore for producing those 😄

@peterdudfield
Copy link

Thanks @jakirkham - worked for me

@martindurant martindurant mentioned this issue Apr 22, 2022
7 tasks
@joshmoore
Copy link
Member

Closing but please speak up if there are any remaining issues.

talonchandler added a commit to mehta-lab/recOrder that referenced this issue Jun 21, 2022
Can reinstate when `numcodecs` releases 3.10 to PyPI.

Related issue: zarr-developers/numcodecs#308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants