-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release wheel for 3.10 #308
Comments
I think conda-forge has built for 3.10 already, if that will do. |
That's a good workaround - but I expect that there will be people who use pip primarily who will also run into this. e.g. i ran into this when doing pip install of different pacakge and it caught me off gaurd. No rush from me to fix, just wanted to bring it up |
Sure, we need to update the release too. |
We build wheels with Currently CI doesn't cover Python 3.10. So adding that would be good to do. If someone would like to do a PR to add Python 3.10, that would be a good first step towards addressing this. Not expecting any major issues there, but if they come happy to discuss. @ianhi would you be interested in giving this a try? 🙂 |
Yes, only if it is up to date |
Good point. Added to the comment above |
This is one of the remaining not-on-3.10 yet wheels pyodide pyodide/pyodide#978. Do you still support Python 2? If so, then bumping to cibuildwheel 2.3.1 will drop 2.7 & 3.5 wheels - which is probably a good idea, since the only supported way to make them today is to use manylinux1, which is past EOL and hanging on by a thread. But you can split the job in two and use old cibuildwheel for old Python versions if that's the case. Otherwise, it should be a pretty simple bump. |
Excellent, no Python <3.6 support, so should be a simple version bump. If you use our Action, you can even have GitHub Dependabot update this regularly for you. Minor request, could you please remove the <4 from your Python requires? It causes issues for locking packages managers, and is discouraged. See https://iscinumpy.dev/post/bound-version-constraints/, https://discuss.python.org/t/requires-python-upper-limits, and cjolowicz/cookiecutter-hypermodern-python#1154 for some context / issues related to this. |
What would need to be done to set this up? |
On a side note, would be curious to learn more about how Pyodide & Zarr are being used together. Opened issue ( zarr-developers/community#43 ) for discussion on this 🙂 |
We've now added Python 3.10 testing and enabled Python 3.10 wheel builds. All of this thanks to Henry's PR ( #309 ) 😀 Packages are not published yet, but think we are ready to do that next (assuming no other blockers) |
Wheels are now available for testing under |
Thanks @jakirkham - worked for me |
Closing but please speak up if there are any remaining issues. |
Can reinstate when `numcodecs` releases 3.10 to PyPI. Related issue: zarr-developers/numcodecs#308
Minimal, reproducible code sample, a copy-pastable example if possible
Problem description
Above code spends some time building the wheel. Which may fail on some systems and also slows down install times. It would be great to bump CI python versions and release the new wheels.
Version and installation information
Please provide the following:
numcodecs.__version__
0.9.1The text was updated successfully, but these errors were encountered: