-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ci): test on windows and osx #2431
Conversation
…into ci/expand-ci-matrix
@zarr-developers/python-core-devs - do we have any Window's |
fsspec has a decent amount of work for this which you can reuse. Actually, could RemoteStore write to local too to avoid the duplication, or would that be unnecessarily complicated (given the async/sync difference in particular). |
Can you provide some pointers?
I don't think this will help us because the |
fsspec calls https://github.com/fsspec/filesystem_spec/blob/master/fsspec/implementations/local.py#L284 as early as possible in localFS, since posix paths always work on windows in python (but not the other way around). |
# - python-version: '3.11' | ||
# numpy-version: '1.25' | ||
# dependency-set: 'optional' | ||
# os: 'windows-latest' | ||
# - python-version: '3.13' | ||
# numpy-version: '2.1' | ||
# dependency-set: 'optional' | ||
# os: 'windows-latest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened a dedicated ticket for this: #2438
pre-commit.ci autofix |
This PR adds CI matrix entries for OSX and Windows.
Closes #1648
Notes:
There are some interesting failures here.
- [ ] path handling in local store