Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more ruff rules #2460

Merged
merged 14 commits into from
Nov 5, 2024
Merged

Add more ruff rules #2460

merged 14 commits into from
Nov 5, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jhamman
Copy link
Member

jhamman commented Nov 4, 2024

This looks like a nice set of changes. @DimitriPapadopoulos - can you fix the last remaining lint error and we can merge.

@DimitriPapadopoulos
Apply ruff/flake8-simplify rule SIM114
8fc5bde 
SIM114 Combine `if` branches using logical `or` operator
@jhamman jhamman merged commit ca46bab into zarr-developers:main Nov 5, 2024
24 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the final_ruff branch November 5, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @jhamman