Adding methods to get computed props #3395
Conversation
Adding methods to get computed props from Quasar elements, using the QTable as a proof of principle
Adding methods to get computed props from Quasar elements, using the QTable as a proof of principle
Adding methods to get computed props from Quasar elements, using the QTable as a proof of principle
Adding methods to get computed props from Quasar elements, using the QTable as a proof of principle
Adding methods to get computed props from Quasar elements, using the QTable as a proof of principle
There was a problem hiding this comment.
Thanks for the pull request, @srobertson86!
I just reviewed your code and made some minor changes. The one thing I wasn't so sure about were these async properties. Even though they are technically possible in Python, they kind of contradict the convention of properties being used for quick, cheap attribute access, while methods are for more costly acquisitions. In this case we need to await a websocket request, which can take significant time. And we don't want the users to accidentally access the async property repeatedly in a for-loop, but do it once before iterating over the resulting list. Long story short, I think it is better to use async methods, like we do, e.g., for ui.aggrid.get_selected_rows.
Adding methods to get computed props from Quasar elements, using the QTable as a proof of principle