Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiCameraProvider camera scanning #139

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Conversation

NiklasNeugebauer
Copy link
Contributor

@NiklasNeugebauer NiklasNeugebauer commented Jun 20, 2024

This adds the scan_for_cameras method to the MultiCameraProvider which in turn calls it on all its providers.
For this, all CameraProviders need to support the scan_for_cameras method which is now an abstract method of the parent class.

Adding the method as an abstractmethod may require action on all derived CameraProviders outside of rosys.
Another option would be to add it as a default that does nothing.

The central question here would be if all providers can scan for new cameras somehow or if some need a fixed list provided by the application code.

@falkoschindler falkoschindler marked this pull request as ready for review July 9, 2024 13:51
@falkoschindler falkoschindler added this to the 0.11.0 milestone Jul 9, 2024
@falkoschindler falkoschindler added the enhancement New feature or request label Jul 9, 2024
@falkoschindler falkoschindler merged commit eacddd5 into main Jul 9, 2024
2 checks passed
@falkoschindler falkoschindler deleted the multi-provider-scanning branch July 9, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants