Support tracking multiple tasks #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodja
approved these changes
Jul 15, 2024
|
I just merged this PR with the new implementation #150 and successfully tested with the following demo: from nicegui import ui
import rosys
@rosys.analysis.track
async def short():
await rosys.sleep(0.25)
@rosys.analysis.track
async def long():
await rosys.sleep(0.75)
@rosys.analysis.track
async def run() -> None:
await rosys.automation.parallelize(short(), long())
automator1 = rosys.automation.Automator(None, default_automation=run)
automator2 = rosys.automation.Automator(None, default_automation=run)
rosys.automation.automation_controls(automator1)
rosys.automation.automation_controls(automator2)
rosys.analysis.track.ui()
ui.run() |
codingpaula
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to NiceGUI's slot stacks, this PR implements separate
@trackstacks per task ID. Originally this was meant to solve issue #147, but it turned out that parallelized coroutines share the same task ID. Nevertheless, this PR should prevent the track stack from getting scrambled when calling tracked coroutines from different tasks, e.g. by clicking UI buttons.