Fix breaking dependency #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove debug prints
falkoschindler
changed the title
falkoschindler
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Ok, the solution seems reasonable.
It just bugs me that we still don't know which package upgrade caused the problem. And we can't be 100% sure it won't affect backup data on real devices.
What do you think, @rodja?
rodja
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: With updated packages, running test_examples.py sporadically creates empty
rosys.config.json(persistence for theConfigclass), which breaks the examples that are run afterwards.My best guess is that there is some kind of race condition where the backup function was called and started clearing the file but did not finish before the task was cancelled.
It seems to me that the errors never impacted normal programs.
I was able to (accidentally) lower the chance of the empty write happening by adding some debug prints (see ef750a9).
In the end, I decided to first write to a .tmp file and then rename the file. If the write is somehow cancelled, then only the tmp file will be empty.
Opinions?
@rodja @falkoschindler