Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting parameters on disconnected cameras #160

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

NiklasNeugebauer
Copy link
Contributor

Currently, when setting parameters the camera checks if it is connected and simply drops the values if it is not (with the idea that if we cannot set the values on the camera then we cannot do anything).

This PR now saves the values to cache if the camera is disconnected so that upon a reconnect, the values will be applied.

@NiklasNeugebauer NiklasNeugebauer added this to the 0.12.0 milestone Jul 26, 2024
@NiklasNeugebauer
Copy link
Contributor Author

As with #159 I will test this on Monday

@falkoschindler falkoschindler modified the milestones: 0.12.0, 0.13.0, 0.14.0 Jul 29, 2024
@NiklasNeugebauer NiklasNeugebauer marked this pull request as ready for review August 8, 2024 10:59
Copy link
Contributor

@pascalzauberzeug pascalzauberzeug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pascalzauberzeug pascalzauberzeug merged commit 9b64656 into main Aug 8, 2024
8 checks passed
@pascalzauberzeug pascalzauberzeug deleted the always-set-parameters branch August 8, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants