Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SimulatedCalibratableCamera #169

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

rodja
Copy link
Member

@rodja rodja commented Aug 12, 2024

To avoid rewriting the very simple implementation of a SimulatedCalibratableCamera in every project, this PR adds it to rosys.vision.

NOTE: due to circular dependencies, the implementation was placed in the __init__.py.

@rodja rodja added the enhancement New feature or request label Aug 12, 2024
@rodja rodja added this to the 0.14.0 milestone Aug 12, 2024
Copy link
Contributor

@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange. I just introduced simulated_calibratable_camera.py and don't get any problems with circular imports. Did I miss something?

@rodja
Copy link
Member Author

rodja commented Aug 12, 2024

Strange. It now works for me, too.

@falkoschindler falkoschindler merged commit ba18726 into main Aug 12, 2024
4 checks passed
@falkoschindler falkoschindler deleted the simulated-calibratable-camera branch August 12, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants